Issue 11299257: Fix dartium tests after legacy getter removal

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 11299257: Fix dartium tests after legacy getter removal (Closed)

Created:
8 years ago by hausner

Modified:
8 years ago

Reviewers:
Anton Muhin

CC:
reviews_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

Fix dartium tests after legacy getter removal Committed: https://code.google.com/p/dart/source/detail?r=15536

Patch Set 3 : #

Created: 8 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+18 lines, -18 lines)			Patch
M	sdk/lib/html/dartium/html_dartium.dart	View		2 chunks	+8 lines, -8 lines	0 comments	Download
M	sdk/lib/html/src/native_DOMImplementation.dart	View		1 chunk	+7 lines, -7 lines	0 comments	Download
M	sdk/lib/html/templates/html/dart2js/impl_LocalWindow.darttemplate	View	1 2	2 chunks	+2 lines, -2 lines	0 comments	Download
M	sdk/lib/html/templates/html/impl/impl_DocumentFragment.darttemplate	View	1	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Anton Muhin

lgtm w/ comment addressed And thanks a lot! https://codereview.chromium.org/11299257/diff/1/sdk/lib/html/dart2js/html_dart2js.dart File sdk/lib/html/dart2js/html_dart2js.dart (right): https://codereview.chromium.org/11299257/diff/1/sdk/lib/html/dart2js/html_dart2js.dart#newcode6843 sdk/lib/html/dart2js/html_dart2js.dart:6843: Element ...

8 years ago (2012-11-29 18:59:11 UTC) #2

hausner

8 years ago (2012-11-29 19:07:42 UTC) #3

https://codereview.chromium.org/11299257/diff/1/sdk/lib/html/dart2js/html_dar...
File sdk/lib/html/dart2js/html_dart2js.dart (right):

https://codereview.chromium.org/11299257/diff/1/sdk/lib/html/dart2js/html_dar...
sdk/lib/html/dart2js/html_dart2js.dart:6843: Element get $m_lastElementChild =>
elements.last;
Hmm, I don't find the place where this gets generated :/
On 2012/11/29 18:59:11, Anton Muhin wrote:
> that should be fixed in
>
http://code.google.com/p/dart/source/browse/branches/bleeding_edge/dart/sdk/l...
> 
> This file is autogenerated actually

Expand Messages | Collapse Messages

Issue 11299257: Fix dartium tests after legacy getter removal (Closed)

Description

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Messages