Add support for https scheme in dart:io HttpClient.

Add support for https scheme in dart:io HttpClient.


BUG=

Committed: https://code.google.com/p/dart/source/detail?r=15450

[Søren Gjesse, 2012-11-28 12:36:30]

lgtm

https://codereview.chromium.org/11299210/diff/1/sdk/lib/io/http_impl.dart
File sdk/lib/io/http_impl.dart (right):

https://codereview.chromium.org/11299210/diff/1/sdk/lib/io/http_impl.dart#new...
sdk/lib/io/http_impl.dart:1824: Queue socketConnections = _openSockets[key];
How about removing all incompatible sockets here?

while (socketConnections != null &&
       !socketConnections.isEmpty &&
       secure != (socketConnections.first._socket is SecureSocket)) {
socketConnections.removeFirst()._close();

}

https://codereview.chromium.org/11299210/diff/1/sdk/lib/io/http_impl.dart#new...
sdk/lib/io/http_impl.dart:1856: if (secure != (socketConn._socket is
SecureSocket)) {
If you get rid of incompatible connections above this is not needed.

[Bill Hesse, 2012-11-28 14:11:23]

https://codereview.chromium.org/11299210/diff/1/sdk/lib/io/http_impl.dart
File sdk/lib/io/http_impl.dart (right):

https://codereview.chromium.org/11299210/diff/1/sdk/lib/io/http_impl.dart#new...
sdk/lib/io/http_impl.dart:1824: Queue socketConnections = _openSockets[key];
On 2012/11/28 12:36:30, Søren Gjesse wrote:
> How about removing all incompatible sockets here?
> 
> while (socketConnections != null &&
>        !socketConnections.isEmpty &&
>        secure != (socketConnections.first._socket is SecureSocket)) {
> socketConnections.removeFirst()._close();
> 
> }

Done.

https://codereview.chromium.org/11299210/diff/1/sdk/lib/io/http_impl.dart#new...
sdk/lib/io/http_impl.dart:1824: Queue socketConnections = _openSockets[key];
On 2012/11/28 12:36:30, Søren Gjesse wrote:
> How about removing all incompatible sockets here?
> 
> while (socketConnections != null &&
>        !socketConnections.isEmpty &&
>        secure != (socketConnections.first._socket is SecureSocket)) {
> socketConnections.removeFirst()._close();
> 
> }

Done.

https://codereview.chromium.org/11299210/diff/1/sdk/lib/io/http_impl.dart#new...
sdk/lib/io/http_impl.dart:1856: if (secure != (socketConn._socket is
SecureSocket)) {
On 2012/11/28 12:36:30, Søren Gjesse wrote:
> If you get rid of incompatible connections above this is not needed.

Done.

[Mads Ager (google), 2012-11-29 08:29:12]

LGTM

https://codereview.chromium.org/11299210/diff/3003/sdk/lib/io/http_impl.dart
File sdk/lib/io/http_impl.dart (right):

https://codereview.chromium.org/11299210/diff/3003/sdk/lib/io/http_impl.dart#...
sdk/lib/io/http_impl.dart:1873: bool secure = (url.scheme == "https");
I would remove the extra parenthesis here.