Issue 11299047: Add constructors for SVG elements and remove static factory providers for html

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 11299047: Add constructors for SVG elements and remove static factory providers for html (Closed)

Created:
8 years, 1 month ago by Emily Fortuna

Modified:
8 years, 1 month ago

Reviewers:
blois

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Add constructors for SVG elements and remove static factory providers for html elements with fix for optional parameters. BUG= Committed: https://code.google.com/p/dart/source/detail?r=15045

Patch Set 2 : capitalization fix #

Created: 8 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+492 lines, -843 lines)			Patch
M	sdk/lib/html/dart2js/html_dart2js.dart	View		54 chunks	+69 lines, -384 lines	0 comments	Download
M	sdk/lib/html/dartium/html_dartium.dart	View		54 chunks	+69 lines, -384 lines	0 comments	Download
M	sdk/lib/html/scripts/generator.py	View		5 chunks	+49 lines, -7 lines	0 comments	Download
M	sdk/lib/html/scripts/htmldartgenerator.py	View		2 chunks	+16 lines, -9 lines	0 comments	Download
M	sdk/lib/html/scripts/systemhtml.py	View	1	6 chunks	+87 lines, -40 lines	0 comments	Download
M	sdk/lib/html/scripts/systemnative.py	View		1 chunk	+4 lines, -4 lines	0 comments	Download
M	sdk/lib/html/templates/html/impl/factoryprovider_Elements.darttemplate	View		1 chunk	+0 lines, -9 lines	0 comments	Download
M	sdk/lib/svg/dart2js/svg_dart2js.dart	View	1	48 chunks	+96 lines, -0 lines	0 comments	Download
M	sdk/lib/svg/dartium/svg_dartium.dart	View	1	48 chunks	+96 lines, -0 lines	0 comments	Download
M	tests/html/svgelement_test.dart	View		2 chunks	+6 lines, -6 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Emily Fortuna

This time should work with two little changes https://codereview.chromium.org/11299047/diff/1/sdk/lib/html/scripts/generator.py File sdk/lib/html/scripts/generator.py (right): https://codereview.chromium.org/11299047/diff/1/sdk/lib/html/scripts/generator.py#newcode439 sdk/lib/html/scripts/generator.py:439: PARAMS=self.ParametersDeclaration(rename_type), ...

8 years, 1 month ago (2012-11-16 22:30:07 UTC) #1

lgtm

Expand Messages | Collapse Messages

Issue 11299047: Add constructors for SVG elements and remove static factory providers for html (Closed)

Description

Patch Set 1 #

Patch Set 2 : capitalization fix #

Messages