Issue 11299028: Move CurlClient to Pub so that it can access resources.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 11299028: Move CurlClient to Pub so that it can access resources. (Closed)

Created:
8 years, 1 month ago by nweiz

Modified:
8 years, 1 month ago

Reviewers:
Bob Nystrom

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Move CurlClient to Pub so that it can access resources. This CL also enables tests for the client on Linux and OS X. Committed: https://code.google.com/p/dart/source/detail?r=15047

Patch Set 2 : Code review change #

Created: 8 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+76 lines, -516 lines)			Patch
M	pkg/http/lib/http.dart	View		1 chunk	+0 lines, -1 line	0 comments	Download
D	pkg/http/lib/src/curl_client.dart	View		1 chunk	+0 lines, -187 lines	0 comments	Download
M	pkg/http/lib/src/utils.dart	View		1 chunk	+0 lines, -23 lines	0 comments	Download
D	pkg/http/test/curl_client_test.dart	View		1 chunk	+0 lines, -263 lines	0 comments	Download
M	pkg/pkg.status	View		1 chunk	+0 lines, -4 lines	0 comments	Download
A +	utils/pub/curl_client.dart	View		8 chunks	+15 lines, -15 lines	0 comments	Download
M	utils/pub/io.dart	View		1 chunk	+13 lines, -0 lines	0 comments	Download
M	utils/pub/utils.dart	View		1 chunk	+21 lines, -0 lines	0 comments	Download
A +	utils/tests/pub/curl_client_test.dart	View		11 chunks	+24 lines, -23 lines	0 comments	Download
M	utils/tests/pub/pub.status	View	1	1 chunk	+3 lines, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Bob Nystrom

One request, otherwise LGTM. https://codereview.chromium.org/11299028/diff/1/utils/tests/pub/pub.status File utils/tests/pub/pub.status (right): https://codereview.chromium.org/11299028/diff/1/utils/tests/pub/pub.status#newcode18 utils/tests/pub/pub.status:18: # TODO(nweiz): enable this on ...

8 years, 1 month ago (2012-11-17 00:46:26 UTC) #2

nweiz

8 years, 1 month ago (2012-11-17 01:09:08 UTC) #3

https://codereview.chromium.org/11299028/diff/1/utils/tests/pub/pub.status
File utils/tests/pub/pub.status (right):

https://codereview.chromium.org/11299028/diff/1/utils/tests/pub/pub.status#ne...
utils/tests/pub/pub.status:18: # TODO(nweiz): enable this on Windows when we
have a binary checked in
On 2012/11/17 00:46:26, Bob Nystrom wrote:
> Can you file a bug for this and put the number here?

Done.

Expand Messages | Collapse Messages

Issue 11299028: Move CurlClient to Pub so that it can access resources. (Closed)

Description

Patch Set 1 #

Patch Set 2 : Code review change #

Messages