Issue 11299005: Avoid repeated lower-casing of the same string when adding HTTP

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 11299005: Avoid repeated lower-casing of the same string when adding HTTP (Closed)

Created:
8 years, 1 month ago by Mads Ager (google)

Modified:
8 years, 1 month ago

Reviewers:
Søren Gjesse, Anders Johnsen

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Avoid repeated lower-casing of the same string when adding HTTP headers. R=sgjesse@google.com,ajohnsen@google.com BUG= Committed: https://code.google.com/p/dart/source/detail?r=14956

Patch Set 1 #

Total comments: 1

Created: 8 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+7 lines, -6 lines)			Patch
	M	sdk/lib/io/http_impl.dart	View		5 chunks	+7 lines, -6 lines	1 comment	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Søren Gjesse

8 years, 1 month ago (2012-11-15 12:24:11 UTC) #3

lgtm

https://codereview.chromium.org/11299005/diff/1/sdk/lib/io/http_impl.dart
File sdk/lib/io/http_impl.dart (right):

https://codereview.chromium.org/11299005/diff/1/sdk/lib/io/http_impl.dart#new...
sdk/lib/io/http_impl.dart:207: name = lowerCaseName;
This line is not needed. Just use lowerCaseName two times below.

Expand Messages | Collapse Messages