Issue 1129693005: MutableVariable no longer has a host Element.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1129693005: MutableVariable no longer has a host Element. (Closed)

Created:
5 years, 7 months ago by asgerf

Modified:
5 years, 7 months ago

Reviewers:
Kevin Millikin (Google)

CC:
reviews_dartlang.org

Base URL:
git@github.com:dart-lang/sdk.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

MutableVariable no longer has a host Element. This fixes a bug when mutable variables occur in constructor elements, similar to an earlier bug where mutable variables in nested functions would fail to use the right element. Hopefully we've seen the last of it now. BUG= R=kmillikin@google.com Committed: https://github.com/dart-lang/sdk/commit/7d4a8df4967c228535fa601ac61db2bcb65ee3e9

Created: 5 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+6 lines, -17 lines)			Patch
M	pkg/compiler/lib/src/cps_ir/cps_ir_builder.dart	View		2 chunks	+3 lines, -10 lines	0 comments	Download
M	pkg/compiler/lib/src/cps_ir/cps_ir_nodes.dart	View		1 chunk	+1 line, -3 lines	0 comments	Download
M	pkg/compiler/lib/src/tree_ir/tree_ir_builder.dart	View		2 chunks	+1 line, -2 lines	0 comments	Download
M	tests/compiler/dart2js/backend_dart/sexpr_unstringifier.dart	View	1	1 chunk	+1 line, -2 lines	0 comments	Download

Total messages: 4 (1 generated)

asgerf

5 years, 7 months ago (2015-05-20 08:29:12 UTC) #4

Message was sent while issue was closed.

Committed patchset #2 (id:20001) manually as
7d4a8df4967c228535fa601ac61db2bcb65ee3e9 (presubmit successful).