Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(195)

Issue 1129563002: Create a class for evaluating const instance creation expressions. (Closed)

Created:
5 years, 7 months ago by Paul Berry
Modified:
5 years, 7 months ago
CC:
reviews_dartlang.org
Target Ref:
refs/remotes/git-svn
Visibility:
Public.

Description

Create a class for evaluating const instance creation expressions. Previously the methods for evaluating const instance creation expressions were all in the ConstantValueComputer class. Moving them to their own class allows for the possibility of evaluating them in the ConstantVisitor, which in a future CL should allow us to avoid making these expressions part of the const dependency graph. R=brianwilkerson@google.com Committed: https://code.google.com/p/dart/source/detail?r=45533

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1052 lines, -1012 lines) Patch
M pkg/analyzer/lib/src/generated/constant.dart View 6 chunks +979 lines, -959 lines 0 comments Download
M pkg/analyzer/lib/src/generated/incremental_resolver.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M pkg/analyzer/lib/src/generated/resolver.dart View 9 chunks +27 lines, -15 lines 0 comments Download
M pkg/analyzer/test/generated/all_the_rest_test.dart View 8 chunks +44 lines, -36 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
Paul Berry
Mostly this is just code motion. The diffs make this look like a much larger ...
5 years, 7 months ago (2015-05-05 16:30:32 UTC) #2
Brian Wilkerson
LGTM
5 years, 7 months ago (2015-05-05 17:35:31 UTC) #3
Paul Berry
5 years, 7 months ago (2015-05-05 17:47:46 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as 45533 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698