Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(113)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 112953006: Adding Shadow DOM polyfill to Angular tests (Closed)

Created:
6 years, 11 months ago by blois
Modified:
6 years, 11 months ago
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Adding Shadow DOM polyfill to Angular tests Some of the Angular tests require shadow dom, so adding the polyfill to all of the HTML tests. Updated files are: - pkg/pkg.status - third_party/pkg/update_angular.sh All others are auto-generated. BUG=15929 R=sigmund@google.com Committed: https://code.google.com/p/dart/source/detail?r=31527

Patch Set 1 : #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+201 lines, -120 lines) Patch
M pkg/pkg.status View 1 chunk +0 lines, -4 lines 0 comments Download
A + pkg/third_party/angular_tests/_specs_test.html View 3 chunks +3 lines, -2 lines 0 comments Download
A + pkg/third_party/angular_tests/angular_test.html View 3 chunks +3 lines, -2 lines 0 comments Download
A + pkg/third_party/angular_tests/bootstrap_test.html View 3 chunks +3 lines, -2 lines 0 comments Download
A + pkg/third_party/angular_tests/core/cache_test.html View 3 chunks +3 lines, -2 lines 0 comments Download
A + pkg/third_party/angular_tests/core/interpolate_test.html View 3 chunks +3 lines, -2 lines 0 comments Download
A + pkg/third_party/angular_tests/core/parser/generated_getter_setter_test.html View 3 chunks +3 lines, -2 lines 0 comments Download
A + pkg/third_party/angular_tests/core/parser/lexer_test.html View 3 chunks +3 lines, -2 lines 0 comments Download
A + pkg/third_party/angular_tests/core/parser/parser_test.html View 3 chunks +3 lines, -2 lines 0 comments Download
A + pkg/third_party/angular_tests/core/parser/static_parser_test.html View 3 chunks +3 lines, -2 lines 0 comments Download
A + pkg/third_party/angular_tests/core/registry_test.html View 3 chunks +3 lines, -2 lines 0 comments Download
A + pkg/third_party/angular_tests/core/scope_test.html View 3 chunks +3 lines, -2 lines 0 comments Download
A + pkg/third_party/angular_tests/core/templateurl_test.html View 3 chunks +3 lines, -2 lines 0 comments Download
A + pkg/third_party/angular_tests/core/zone_test.html View 3 chunks +3 lines, -2 lines 0 comments Download
A + pkg/third_party/angular_tests/core_dom/block_test.html View 3 chunks +3 lines, -2 lines 0 comments Download
A + pkg/third_party/angular_tests/core_dom/compiler_test.html View 3 chunks +3 lines, -2 lines 0 comments Download
A + pkg/third_party/angular_tests/core_dom/cookies_test.html View 3 chunks +3 lines, -2 lines 0 comments Download
A + pkg/third_party/angular_tests/core_dom/directive_test.html View 3 chunks +3 lines, -2 lines 0 comments Download
A + pkg/third_party/angular_tests/core_dom/http_test.html View 3 chunks +3 lines, -2 lines 0 comments Download
A + pkg/third_party/angular_tests/core_dom/ng_mustache_test.html View 3 chunks +3 lines, -2 lines 0 comments Download
A + pkg/third_party/angular_tests/core_dom/node_cursor_test.html View 3 chunks +3 lines, -2 lines 0 comments Download
A + pkg/third_party/angular_tests/core_dom/selector_test.html View 3 chunks +3 lines, -2 lines 0 comments Download
A + pkg/third_party/angular_tests/core_dom/shadow_root_options_test.html View 3 chunks +3 lines, -2 lines 0 comments Download
A + pkg/third_party/angular_tests/directive/input_select_test.html View 3 chunks +3 lines, -2 lines 0 comments Download
A + pkg/third_party/angular_tests/directive/ng_a_test.html View 3 chunks +3 lines, -2 lines 0 comments Download
A + pkg/third_party/angular_tests/directive/ng_bind_html_test.html View 3 chunks +3 lines, -2 lines 0 comments Download
A + pkg/third_party/angular_tests/directive/ng_bind_template_test.html View 3 chunks +3 lines, -2 lines 0 comments Download
A + pkg/third_party/angular_tests/directive/ng_bind_test.html View 3 chunks +3 lines, -2 lines 0 comments Download
A + pkg/third_party/angular_tests/directive/ng_class_test.html View 3 chunks +3 lines, -2 lines 0 comments Download
A + pkg/third_party/angular_tests/directive/ng_cloak_test.html View 3 chunks +3 lines, -2 lines 0 comments Download
A + pkg/third_party/angular_tests/directive/ng_events_test.html View 3 chunks +3 lines, -2 lines 0 comments Download
A + pkg/third_party/angular_tests/directive/ng_form_test.html View 3 chunks +3 lines, -2 lines 0 comments Download
A + pkg/third_party/angular_tests/directive/ng_if_test.html View 3 chunks +3 lines, -2 lines 0 comments Download
A + pkg/third_party/angular_tests/directive/ng_include_test.html View 3 chunks +3 lines, -2 lines 0 comments Download
A + pkg/third_party/angular_tests/directive/ng_model_test.html View 3 chunks +3 lines, -2 lines 0 comments Download
A + pkg/third_party/angular_tests/directive/ng_non_bindable_test.html View 3 chunks +3 lines, -2 lines 0 comments Download
A + pkg/third_party/angular_tests/directive/ng_repeat_test.html View 3 chunks +3 lines, -2 lines 0 comments Download
A + pkg/third_party/angular_tests/directive/ng_show_hide_test.html View 3 chunks +3 lines, -2 lines 0 comments Download
A + pkg/third_party/angular_tests/directive/ng_src_boolean_test.html View 3 chunks +3 lines, -2 lines 0 comments Download
A + pkg/third_party/angular_tests/directive/ng_style_test.html View 3 chunks +3 lines, -2 lines 0 comments Download
A + pkg/third_party/angular_tests/directive/ng_switch_test.html View 3 chunks +3 lines, -2 lines 0 comments Download
A + pkg/third_party/angular_tests/directive/ng_template_test.html View 3 chunks +3 lines, -2 lines 0 comments Download
A + pkg/third_party/angular_tests/filter/currency_test.html View 3 chunks +3 lines, -2 lines 0 comments Download
A + pkg/third_party/angular_tests/filter/date_test.html View 3 chunks +3 lines, -2 lines 0 comments Download
A + pkg/third_party/angular_tests/filter/filter_test.html View 3 chunks +3 lines, -2 lines 0 comments Download
A + pkg/third_party/angular_tests/filter/json_test.html View 3 chunks +3 lines, -2 lines 0 comments Download
A + pkg/third_party/angular_tests/filter/limit_to_test.html View 3 chunks +3 lines, -2 lines 0 comments Download
A + pkg/third_party/angular_tests/filter/lowercase_test.html View 3 chunks +3 lines, -2 lines 0 comments Download
A + pkg/third_party/angular_tests/filter/number_test.html View 3 chunks +3 lines, -2 lines 0 comments Download
A + pkg/third_party/angular_tests/filter/order_by_test.html View 3 chunks +3 lines, -2 lines 0 comments Download
A + pkg/third_party/angular_tests/filter/uppercase_test.html View 3 chunks +3 lines, -2 lines 0 comments Download
A + pkg/third_party/angular_tests/introspection_test.html View 3 chunks +3 lines, -2 lines 0 comments Download
A + pkg/third_party/angular_tests/mock/http_backend_test.html View 3 chunks +3 lines, -2 lines 0 comments Download
A + pkg/third_party/angular_tests/mock/test_bed_test.html View 3 chunks +3 lines, -2 lines 0 comments Download
A + pkg/third_party/angular_tests/mock/zone_test.html View 3 chunks +3 lines, -2 lines 0 comments Download
A + pkg/third_party/angular_tests/routing/ng_bind_route_test.html View 3 chunks +3 lines, -2 lines 0 comments Download
A + pkg/third_party/angular_tests/routing/ng_view_test.html View 3 chunks +3 lines, -2 lines 0 comments Download
A + pkg/third_party/angular_tests/routing/routing_test.html View 3 chunks +3 lines, -2 lines 0 comments Download
M third_party/pkg/update_angular.sh View 2 chunks +30 lines, -2 lines 2 comments Download

Messages

Total messages: 4 (0 generated)
blois
6 years, 11 months ago (2014-01-07 00:17:55 UTC) #1
Siggi Cherem (dart-lang)
lgtm https://codereview.chromium.org/112953006/diff/30001/third_party/pkg/update_angular.sh File third_party/pkg/update_angular.sh (right): https://codereview.chromium.org/112953006/diff/30001/third_party/pkg/update_angular.sh#newcode83 third_party/pkg/update_angular.sh:83: <script src="/packages/shadow_dom/shadow_dom.debug.js"></script> I thought this had to be ...
6 years, 11 months ago (2014-01-07 00:33:24 UTC) #2
blois
https://codereview.chromium.org/112953006/diff/30001/third_party/pkg/update_angular.sh File third_party/pkg/update_angular.sh (right): https://codereview.chromium.org/112953006/diff/30001/third_party/pkg/update_angular.sh#newcode83 third_party/pkg/update_angular.sh:83: <script src="/packages/shadow_dom/shadow_dom.debug.js"></script> On 2014/01/07 00:33:24, Siggi Cherem (dart-lang) wrote: ...
6 years, 11 months ago (2014-01-07 00:42:41 UTC) #3
blois
6 years, 11 months ago (2014-01-07 00:44:11 UTC) #4
Message was sent while issue was closed. 
Committed patchset #1 manually as r31527 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698