Issue 1129403002: Revert "pub: don't start the admin server if no --admin-port flag was given."

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1129403002: Revert "pub: don't start the admin server if no --admin-port flag was given." (Closed)

Created:
5 years, 7 months ago by ricow1

Modified:
5 years, 7 months ago

Reviewers:
floitsch

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Target Ref:
refs/remotes/git-svn

Visibility:
Public.

Revert "pub: don't start the admin server if no --admin-port flag was given." This reverts commit 45614 Causes redness on the bots, floitsch@ will investigate offline R=floitsch@google.com BUG= Committed: https://code.google.com/p/dart/source/detail?r=45633

Created: 5 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+14 lines, -12 lines)			Patch
	M	sdk/lib/_internal/pub/lib/src/barback/asset_environment.dart	View		1 chunk	+5 lines, -1 line	0 comments	Download
	M	sdk/lib/_internal/pub/lib/src/command/serve.dart	View		1 chunk	+9 lines, -11 lines	0 comments	Download

Total messages: 3 (0 generated)

ricow1

Committed patchset #1 (id:1) manually as 45633 (presubmit successful).

5 years, 7 months ago (2015-05-08 08:13:22 UTC) #2

Message was sent while issue was closed.

LGTM.