Issue 1129383004: Cleanup main annotated steps script

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1129383004: Cleanup main annotated steps script (Closed)

Created:
5 years, 7 months ago by ricow1

Modified:
5 years, 7 months ago

Reviewers:
Bill Hesse

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Target Ref:
refs/remotes/git-svn

Visibility:
Public.

More Reviews

Description

Cleanup main annotated steps script A lot of old stuff that we no longer need. R=whesse@google.com BUG= Committed: https://code.google.com/p/dart/source/detail?r=45732

Patch Set 2 : Better comment #

Total comments: 2

Patch Set 3 : Address review comments #

Created: 5 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+7 lines, -114 lines)			Patch
	M	client/tools/buildbot_annotated_steps.py	View	1 2	6 chunks	+7 lines, -114 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Bill Hesse

lgtm https://codereview.chromium.org/1129383004/diff/20001/client/tools/buildbot_annotated_steps.py File client/tools/buildbot_annotated_steps.py (right): https://codereview.chromium.org/1129383004/diff/20001/client/tools/buildbot_annotated_steps.py#newcode12 client/tools/buildbot_annotated_steps.py:12: This script will based on the name of ...

5 years, 7 months ago (2015-05-12 10:45:42 UTC) #2

ricow1

https://codereview.chromium.org/1129383004/diff/20001/client/tools/buildbot_annotated_steps.py File client/tools/buildbot_annotated_steps.py (right): https://codereview.chromium.org/1129383004/diff/20001/client/tools/buildbot_annotated_steps.py#newcode12 client/tools/buildbot_annotated_steps.py:12: This script will based on the name of the ...

5 years, 7 months ago (2015-05-12 10:47:16 UTC) #3