Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(20)

Issue 1129333003: dart2js: Use JavaScript asts instead of CodeBuffers when assembling output units. (Closed)

Created:
5 years, 7 months ago by herhut
Modified:
5 years, 7 months ago
Reviewers:
Johnni Winther
CC:
reviews_dartlang.org, sra1, floitsch
Target Ref:
refs/remotes/git-svn
Visibility:
Public.

Description

dart2js: Use JavaScript asts instead of CodeBuffers when assembling output units. BUG= R=johnniwinther@google.com Committed: https://code.google.com/p/dart/source/detail?r=45635

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+48 lines, -47 lines) Patch
M pkg/compiler/lib/src/js/js.dart View 1 chunk +0 lines, -1 line 0 comments Download
M pkg/compiler/lib/src/js_emitter/old_emitter/emitter.dart View 11 chunks +46 lines, -46 lines 0 comments Download
M pkg/js_ast/lib/src/builder.dart View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
herhut
5 years, 7 months ago (2015-05-08 08:23:42 UTC) #3
herhut
5 years, 7 months ago (2015-05-08 08:23:42 UTC) #4
Johnni Winther
lgtm
5 years, 7 months ago (2015-05-08 08:48:37 UTC) #5
herhut
5 years, 7 months ago (2015-05-08 08:57:58 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as 45635 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698