Add constructors for SVG elements and remove static factory providers for html elements.

Add constructors for SVG elements and remove static Factory providers for Html
elements.
Committed: https://code.google.com/p/dart/source/detail?r=15020

[blois, 2012-11-15 01:35:49]

https://codereview.chromium.org/11293292/diff/7002/sdk/lib/html/scripts/syste...
File sdk/lib/html/scripts/systemhtml.py (right):

https://codereview.chromium.org/11293292/diff/7002/sdk/lib/html/scripts/syste...
sdk/lib/html/scripts/systemhtml.py:241: emitted_string += '    $CLASS _e =
document.$dom_createElement("$TAG");\n'
Should just be able to use _SVGElementFactoryProvider.createSVGElement_tag(tag).

https://codereview.chromium.org/11293292/diff/7002/sdk/lib/html/scripts/syste...
sdk/lib/html/scripts/systemhtml.py:331: element_str = '_SvgElements'
We should be able to just get rid of these factory methods.

[Emily Fortuna, 2012-11-15 01:36:50]

https://codereview.chromium.org/11293292/diff/7002/sdk/lib/html/scripts/syste...
File sdk/lib/html/scripts/systemhtml.py (right):

https://codereview.chromium.org/11293292/diff/7002/sdk/lib/html/scripts/syste...
sdk/lib/html/scripts/systemhtml.py:241: emitted_string += '    $CLASS _e =
document.$dom_createElement("$TAG");\n'
On 2012/11/15 01:35:49, blois wrote:
> Should just be able to use
_SVGElementFactoryProvider.createSVGElement_tag(tag).

See below for the SVG cases. This is for the HtmlElements.

[blois, 2012-11-15 18:09:15]

https://codereview.chromium.org/11293292/diff/8/sdk/lib/html/scripts/systemht...
File sdk/lib/html/scripts/systemhtml.py (right):

https://codereview.chromium.org/11293292/diff/8/sdk/lib/html/scripts/systemht...
sdk/lib/html/scripts/systemhtml.py:243: '    final Element _e =\n'
Change final Element _e and $CLASS _e to var e.

https://codereview.chromium.org/11293292/diff/8/sdk/lib/html/scripts/systemht...
sdk/lib/html/scripts/systemhtml.py:321: infos =
ElementConstructorInfos(interface_name, _html_element_constructors)
Can we instead do a map of constructor infos, and use self._library_name as the
key?

https://codereview.chromium.org/11293292/diff/8/sdk/lib/html/scripts/systemht...
sdk/lib/html/scripts/systemhtml.py:333: EmitElementFactoryConstructors(
Can we eliminate this completely?

[Emily Fortuna, 2012-11-16 03:34:17]

whew! PTAL.

[blois, 2012-11-16 17:39:05]

https://codereview.chromium.org/11293292/diff/17008/sdk/lib/html/scripts/gene...
File sdk/lib/html/scripts/generator.py (right):

https://codereview.chromium.org/11293292/diff/17008/sdk/lib/html/scripts/gene...
sdk/lib/html/scripts/generator.py:432: '    var _e =
$FACTORY.$CTOR_FACTORY_NAME($FACTORY_PARAMS);\n'
Can this not use underscore for the variable name?

https://codereview.chromium.org/11293292/diff/17008/sdk/lib/html/scripts/syst...
File sdk/lib/html/scripts/systemhtml.py (right):

https://codereview.chromium.org/11293292/diff/17008/sdk/lib/html/scripts/syst...
sdk/lib/html/scripts/systemhtml.py:201: # TODO(efortuna): The following still
need to be added to this list. Currently
I'd remove the TODO and these items. They are unimportant.

I'd probably also remove a number of the ones from above.

[Emily Fortuna, 2012-11-16 17:50:43]

alrighty. suggestions fixed. ptal.

https://codereview.chromium.org/11293292/diff/17008/sdk/lib/html/scripts/gene...
File sdk/lib/html/scripts/generator.py (right):

https://codereview.chromium.org/11293292/diff/17008/sdk/lib/html/scripts/gene...
sdk/lib/html/scripts/generator.py:432: '    var _e =
$FACTORY.$CTOR_FACTORY_NAME($FACTORY_PARAMS);\n'
On 2012/11/16 17:39:05, blois wrote:
> Can this not use underscore for the variable name?

Fixed. That just had an underscore because that's how it was written in the
static factory version.

https://codereview.chromium.org/11293292/diff/17008/sdk/lib/html/scripts/syst...
File sdk/lib/html/scripts/systemhtml.py (right):

https://codereview.chromium.org/11293292/diff/17008/sdk/lib/html/scripts/syst...
sdk/lib/html/scripts/systemhtml.py:201: # TODO(efortuna): The following still
need to be added to this list. Currently
On 2012/11/16 17:39:05, blois wrote:
> I'd remove the TODO and these items. They are unimportant.
> 
> I'd probably also remove a number of the ones from above.

nooo my work! :-) 
Okay.

[blois, 2012-11-16 17:51:52]

lgtm