Issue 11293245: Make interfaces into abstract classes in 'dart:crypto'.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 11293245: Make interfaces into abstract classes in 'dart:crypto'. (Closed)

Created:
8 years, 1 month ago by Anders Johnsen

Modified:
8 years, 1 month ago

Reviewers:
floitsch, Mads Ager (google)

CC:
reviews_dartlang.org, floitsch, Lasse Reichstein Nielsen

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

Make interfaces into abstract classes in 'dart:crypto'. BUG= Committed: https://code.google.com/p/dart/source/detail?r=14835

Created: 8 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+13 lines, -13 lines)			Patch
M	sdk/lib/crypto/crypto.dart	View	4 chunks	+9 lines, -9 lines	0 comments	Download
M	sdk/lib/crypto/crypto_utils.dart	View	1 chunk	+1 line, -1 line	0 comments	Download
M	sdk/lib/crypto/hash_utils.dart	View	2 chunks	+3 lines, -3 lines	0 comments	Download

Total messages: 3 (0 generated)

Anders Johnsen

Ager, can you review, as you are the original author?

8 years, 1 month ago (2012-11-13 09:45:05 UTC) #1

floitsch

8 years, 1 month ago (2012-11-13 13:37:11 UTC) #3

DBC: if constructor-redirectorss work, I would prefer them (since they are more
efficient). But LGTM.