Implement --analyze-all option.

Implement --analyze-all option.

Committed: https://code.google.com/p/dart/source/detail?r=14878

[ahe, 2012-11-13 07:44:15]

Using this option, I was able to report two bugs in our platform libraries,
namely http://dartbug.com/6690, and http://dartbug.com/6691.

[karlklose, 2012-11-13 08:33:47]

LGTM.

https://codereview.chromium.org/11293244/diff/1/dart/sdk/lib/_internal/compil...
File dart/sdk/lib/_internal/compiler/implementation/compiler.dart (right):

https://codereview.chromium.org/11293244/diff/1/dart/sdk/lib/_internal/compil...
dart/sdk/lib/_internal/compiler/implementation/compiler.dart:555: void
fullyEnqueueLibrary(_, LibraryElement library) {
The ignored first argument looks a bit strange. You could use a closure (_, lib)
=> fullyEnqueueLibrary(lib) in l. 529 to get rid of it.

https://codereview.chromium.org/11293244/diff/1/dart/sdk/lib/_internal/compil...
dart/sdk/lib/_internal/compiler/implementation/compiler.dart:560:
element.computeType(this);
Move this computation to ensureResolved?

https://codereview.chromium.org/11293244/diff/1/dart/sdk/lib/_internal/compil...
dart/sdk/lib/_internal/compiler/implementation/compiler.dart:562:
resolver.resolve(element);
Why do you not use ensureResolved here? Is it to make the handling of typedefs
and classes similar (in ResolverTask.resolve)?

https://codereview.chromium.org/11293244/diff/1/dart/sdk/lib/_internal/compil...
File dart/sdk/lib/_internal/compiler/implementation/resolution/members.dart
(right):

https://codereview.chromium.org/11293244/diff/1/dart/sdk/lib/_internal/compil...
dart/sdk/lib/_internal/compiler/implementation/resolution/members.dart:79:
ElementKind kind = element.kind;
Move variable 'kind' down to its use.

[sra1, 2012-11-13 08:38:17]

This is great.
Is there something that is testable?

[ahe, 2012-11-13 13:13:43]

Thank you for your suggestion, especially for reminding me to write a test!

PTAL

Cheers,
Peter

https://codereview.chromium.org/11293244/diff/1/dart/sdk/lib/_internal/compil...
File dart/sdk/lib/_internal/compiler/implementation/compiler.dart (right):

https://codereview.chromium.org/11293244/diff/1/dart/sdk/lib/_internal/compil...
dart/sdk/lib/_internal/compiler/implementation/compiler.dart:555: void
fullyEnqueueLibrary(_, LibraryElement library) {
On 2012/11/13 08:33:47, karlklose wrote:
> The ignored first argument looks a bit strange. You could use a closure (_,
lib)
> => fullyEnqueueLibrary(lib) in l. 529 to get rid of it.

Done.

https://codereview.chromium.org/11293244/diff/1/dart/sdk/lib/_internal/compil...
dart/sdk/lib/_internal/compiler/implementation/compiler.dart:560:
element.computeType(this);
On 2012/11/13 08:33:47, karlklose wrote:
> Move this computation to ensureResolved?

Well, that wouldn't work.  But making sure that all elements can be enqueued
does.

https://codereview.chromium.org/11293244/diff/1/dart/sdk/lib/_internal/compil...
dart/sdk/lib/_internal/compiler/implementation/compiler.dart:562:
resolver.resolve(element);
On 2012/11/13 08:33:47, karlklose wrote:
> Why do you not use ensureResolved here? Is it to make the handling of typedefs
> and classes similar (in ResolverTask.resolve)?

Done.

https://codereview.chromium.org/11293244/diff/1/dart/sdk/lib/_internal/compil...
File dart/sdk/lib/_internal/compiler/implementation/resolution/members.dart
(right):

https://codereview.chromium.org/11293244/diff/1/dart/sdk/lib/_internal/compil...
dart/sdk/lib/_internal/compiler/implementation/resolution/members.dart:79:
ElementKind kind = element.kind;
On 2012/11/13 08:33:47, karlklose wrote:
> Move variable 'kind' down to its use.

Done.

[ngeoffray, 2012-11-13 13:28:37]

LGTM

http://codereview.chromium.org/11293244/diff/5004/dart/sdk/lib/_internal/comp...
File dart/sdk/lib/_internal/compiler/implementation/resolution/members.dart
(right):

http://codereview.chromium.org/11293244/diff/5004/dart/sdk/lib/_internal/comp...
dart/sdk/lib/_internal/compiler/implementation/resolution/members.dart:462: for
(MetadataAnnotation metadata in element.metadata) {
Why is the loop in the resolve method not enough?

[ahe, 2012-11-13 14:55:02]

PTAL, I had to redo the parser changes.

https://codereview.chromium.org/11293244/diff/5004/dart/sdk/lib/_internal/com...
File dart/sdk/lib/_internal/compiler/implementation/resolution/members.dart
(right):

https://codereview.chromium.org/11293244/diff/5004/dart/sdk/lib/_internal/com...
dart/sdk/lib/_internal/compiler/implementation/resolution/members.dart:462: for
(MetadataAnnotation metadata in element.metadata) {
On 2012/11/13 13:28:39, ngeoffray wrote:
> Why is the loop in the resolve method not enough?

There is no guarantee that this method is called by the resolve method.

[sra1, 2012-11-13 18:56:40]

lgtm

https://codereview.chromium.org/11293244/diff/12001/dart/sdk/lib/_internal/co...
File dart/sdk/lib/_internal/compiler/implementation/scanner/listener.dart
(right):

https://codereview.chromium.org/11293244/diff/12001/dart/sdk/lib/_internal/co...
dart/sdk/lib/_internal/compiler/implementation/scanner/listener.dart:1740:
recoverableError('typeArguments not allowed here', node: typeArguments);
If this is a user-facing message, replace typeArguments with real word, e.g.
Type arguments

[ahe, 2012-11-14 17:56:21]

Thanks

https://codereview.chromium.org/11293244/diff/12001/dart/sdk/lib/_internal/co...
File dart/sdk/lib/_internal/compiler/implementation/scanner/listener.dart
(right):

https://codereview.chromium.org/11293244/diff/12001/dart/sdk/lib/_internal/co...
dart/sdk/lib/_internal/compiler/implementation/scanner/listener.dart:1740:
recoverableError('typeArguments not allowed here', node: typeArguments);
On 2012/11/13 18:56:40, sra1 wrote:
> If this is a user-facing message, replace typeArguments with real word, e.g.
> Type arguments

Done in r14889.

[Johnni Winther, 2012-11-19 08:19:32]

lgtm