Issue 11293180: Update library syntax and fix test status.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 11293180: Update library syntax and fix test status. (Closed)

Created:
8 years, 1 month ago by gram

Modified:
8 years, 1 month ago

Reviewers:
Siggi Cherem (dart-lang)

CC:
reviews_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

Update library syntax and fix test status. Committed: https://code.google.com/p/dart/source/detail?r=14699

Patch Set 1 #

Total comments: 1

Created: 8 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+10 lines, -16 lines)			Patch
M	tests/utils/dummy.dart	View	1 chunk	+1 line, -1 line	0 comments	Download
M	tests/utils/json_test.dart	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	tests/utils/png_layout_test.dart	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	tests/utils/test_utils.dart	View	1 chunk	+1 line, -1 line	0 comments	Download
M	tests/utils/txt_layout_test.dart	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	tests/utils/utf8_test.dart	View	1 chunk	+2 lines, -2 lines	1 comment	Download
M	tests/utils/utils.status	View	1 chunk	+0 lines, -6 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Siggi Cherem (dart-lang)

lgtm https://codereview.chromium.org/11293180/diff/1/tests/utils/utf8_test.dart File tests/utils/utf8_test.dart (right): https://codereview.chromium.org/11293180/diff/1/tests/utils/utf8_test.dart#newcode5 tests/utils/utf8_test.dart:5: library Utf8Test; fix library name?

8 years, 1 month ago (2012-11-08 18:14:44 UTC) #2

Siggi Cherem (dart-lang)

8 years, 1 month ago (2012-11-08 18:33:02 UTC) #3

On 2012/11/08 18:14:44, Siggi Cherem (dart-lang) wrote:
> lgtm
> 
> https://codereview.chromium.org/11293180/diff/1/tests/utils/utf8_test.dart
> File tests/utils/utf8_test.dart (right):
> 
>
https://codereview.chromium.org/11293180/diff/1/tests/utils/utf8_test.dart#ne...
> tests/utils/utf8_test.dart:5: library Utf8Test;
> fix library name?

just in general to follow a lower_case_convention

Expand Messages | Collapse Messages