Issue 11293148: Report errors on duplicate export.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 11293148: Report errors on duplicate export. (Closed)

Created:
8 years, 1 month ago by Johnni Winther

Modified:
8 years, 1 month ago

Reviewers:
ahe

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Report errors on duplicate export. Committed: https://code.google.com/p/dart/source/detail?r=14641

Patch Set 2 : Status updated #

Created: 8 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+53 lines, -23 lines)			Patch
M	sdk/lib/_internal/compiler/implementation/library_loader.dart	View	1	3 chunks	+17 lines, -7 lines	0 comments	Download
M	tests/co19/co19-dart2dart.status	View	1	1 chunk	+2 lines, -2 lines	0 comments	Download
M	tests/co19/co19-dart2js.status	View	1	1 chunk	+0 lines, -2 lines	0 comments	Download
A +	tests/language/duplicate_export_negative_test.dart	View	1	1 chunk	+2 lines, -3 lines	0 comments	Download
A +	tests/language/duplicate_import_liba.dart	View	1	1 chunk	+7 lines, -3 lines	0 comments	Download
A +	tests/language/duplicate_import_libb.dart	View	1	1 chunk	+7 lines, -3 lines	0 comments	Download
A +	tests/language/duplicate_import_libc.dart	View	1	1 chunk	+5 lines, -3 lines	0 comments	Download
A	tests/language/duplicate_import_libd.dart	View	1	1 chunk	+13 lines, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

ahe

LGTM! https://codereview.chromium.org/11293148/diff/1/sdk/lib/_internal/compiler/implementation/library_loader.dart File sdk/lib/_internal/compiler/implementation/library_loader.dart (right): https://codereview.chromium.org/11293148/diff/1/sdk/lib/_internal/compiler/implementation/library_loader.dart#newcode552 sdk/lib/_internal/compiler/implementation/library_loader.dart:552: compiler.reportMessage(compiler.spanFromElement(existingElement), existingElement -> element.

8 years, 1 month ago (2012-11-07 14:37:09 UTC) #2

Johnni Winther

8 years, 1 month ago (2012-11-07 17:49:36 UTC) #3

https://codereview.chromium.org/11293148/diff/1/sdk/lib/_internal/compiler/im...
File sdk/lib/_internal/compiler/implementation/library_loader.dart (right):

https://codereview.chromium.org/11293148/diff/1/sdk/lib/_internal/compiler/im...
sdk/lib/_internal/compiler/implementation/library_loader.dart:552:
compiler.reportMessage(compiler.spanFromElement(existingElement),
On 2012/11/07 14:37:09, ahe wrote:
> existingElement -> element.

Done.

Expand Messages | Collapse Messages

Issue 11293148: Report errors on duplicate export. (Closed)

Description

Patch Set 1 #

Patch Set 2 : Status updated #

Messages