Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(37)

Issue 11293031: Remove some unnecessary class handle creations. (Closed)

Created:
8 years, 1 month ago by siva
Modified:
8 years, 1 month ago
Reviewers:
Tom Ball, Ivan Posva
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Visibility:
Public.

Description

Remove some unnecessary class handle creations. Committed: https://code.google.com/p/dart/source/detail?r=14420

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+104 lines, -185 lines) Patch
M vm/object.h View 2 chunks +4 lines, -4 lines 0 comments Download
M vm/object.cc View 29 chunks +99 lines, -177 lines 0 comments Download
M vm/raw_object_snapshot.cc View 1 chunk +1 line, -4 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
siva
8 years, 1 month ago (2012-11-01 01:09:26 UTC) #1
Tom Ball
lgtm: very nice -- much clearer.
8 years, 1 month ago (2012-11-01 16:27:34 UTC) #2
Ivan Posva
8 years, 1 month ago (2012-11-01 16:35:26 UTC) #3
LGTM -ip

Powered by Google App Engine
This is Rietveld 408576698