Issue 11293020: Redirecting constructor may not have function body

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 11293020: Redirecting constructor may not have function body (Closed)

Created:
8 years, 1 month ago by hausner

Modified:
8 years, 1 month ago

Reviewers:
regis

CC:
reviews_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

Redirecting constructor may not have function body Adding a test case and consolidating 3 other tests into the new one. Issue 2030. Committed: https://code.google.com/p/dart/source/detail?r=14376

Patch Set 3 : #

Created: 8 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+31 lines, -60 lines)			Patch
A	tests/language/constructor_redirect2_test.dart	View	1	1 chunk	+29 lines, -0 lines	0 comments	Download
D	tests/language/constructor_redirect3_negative_test.dart	View	1 2	1 chunk	+0 lines, -20 lines	0 comments	Download
D	tests/language/constructor_redirect4_negative_test.dart	View	1 2	1 chunk	+0 lines, -20 lines	0 comments	Download
D	tests/language/constructor_redirect5_negative_test.dart	View	1 2	1 chunk	+0 lines, -20 lines	0 comments	Download
M	tests/language/language.status	View	1 2	1 chunk	+1 line, -0 lines	0 comments	Download
M	tests/language/language_dart2js.status	View	1 2	1 chunk	+1 line, -0 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

regis

Have you hear of Operation "Don't be Negative"? :-) http://codereview.chromium.org/11293020/diff/1/tests/language/constructor_redirect6_negative_test.dart File tests/language/constructor_redirect6_negative_test.dart (right): http://codereview.chromium.org/11293020/diff/1/tests/language/constructor_redirect6_negative_test.dart#newcode9 tests/language/constructor_redirect6_negative_test.dart:9: ...

8 years, 1 month ago (2012-10-31 21:11:04 UTC) #2

LGTM!

Expand Messages | Collapse Messages

Issue 11293020: Redirecting constructor may not have function body (Closed)

Description

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Messages