Issue 11293018: Update semantic highlighting only if there are no parse errors

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 11293018: Update semantic highlighting only if there are no parse errors (Closed)

Created:
8 years, 1 month ago by scheglov

Modified:
8 years, 1 month ago

Reviewers:
messick

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

Update semantic highlighting only if there are no parse errors R=messick@google.com BUG= Committed: https://code.google.com/p/dart/source/detail?r=14364

Created: 8 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+35 lines, -5 lines)			Patch
M	compiler/java/com/google/dart/compiler/ast/DartUnit.java	View	2 chunks	+10 lines, -0 lines	0 comments	Download
M	compiler/java/com/google/dart/compiler/parser/DartParser.java	View	5 chunks	+10 lines, -5 lines	0 comments	Download
M	compiler/javatests/com/google/dart/compiler/parser/SyntaxTest.java	View	1 chunk	+10 lines, -0 lines	0 comments	Download
M	editor/tools/plugins/com.google.dart.tools.ui/src/com/google/dart/tools/ui/internal/text/editor/SemanticHighlightingReconciler.java	View	1 chunk	+5 lines, -0 lines	0 comments	Download

Total messages: 2 (0 generated)

messick

8 years, 1 month ago (2012-10-31 18:53:49 UTC) #2

LGTM

Looking forward to seeing how well this works. I'm still dubious. :)