Issue 1129253005: Add last changes to dartium.deps from svn repo

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1129253005: Add last changes to dartium.deps from svn repo (Closed)

Created:
5 years, 7 months ago by ricow1

Modified:
5 years, 7 months ago

Reviewers:
Bill Hesse

CC:
reviews_dartlang.org

Base URL:
git@github.com:dart-lang/sdk.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

More Reviews

Description

Add last changes to dartium.deps from svn repo I missed the last changes when pulling this in under tools/deps R=whesse@google.com BUG= Committed: https://github.com/dart-lang/sdk/commit/0e7b1ce03c658e77cabf05714b01d2a3333f70d2

Patch Set 1 #

Patch Set 2 : rebase #

Total comments: 1

Created: 5 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+15 lines, -1 line)			Patch
	M	tools/deps/dartium.deps/DEPS	View		2 chunks	+15 lines, -1 line	1 comment	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

ricow1

Committed patchset #2 (id:20001) manually as 0e7b1ce03c658e77cabf05714b01d2a3333f70d2.

5 years, 7 months ago (2015-05-17 07:18:34 UTC) #2

Bill Hesse

5 years, 7 months ago (2015-05-18 15:23:27 UTC) #3

Message was sent while issue was closed.

lgtm

https://codereview.chromium.org/1129253005/diff/20001/tools/deps/dartium.deps...
File tools/deps/dartium.deps/DEPS (right):

https://codereview.chromium.org/1129253005/diff/20001/tools/deps/dartium.deps...
tools/deps/dartium.deps/DEPS:213: "src/dart/tools/testing/bin",
This got fixed in a later CL, to be based on dart_root.

Expand Messages | Collapse Messages