Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(129)

Issue 1129143003: Store elements in the constant eval dependency graph rather than AST nodes. (Closed)

Created:
5 years, 7 months ago by Paul Berry
Modified:
5 years, 7 months ago
Reviewers:
Brian Wilkerson
CC:
reviews_dartlang.org
Target Ref:
refs/remotes/git-svn
Visibility:
Public.

Description

Store elements in the constant eval dependency graph rather than AST nodes. This paves the way for constant evaluation to be integrated into the new task model, since the new tasks for constants will use elements as their targets. Since the element model makes a distinction between constructor members and constructor elements, we have to be careful to be consistent about what kinds of elements are stored in the dependency graph. We always store constructor elements in the dependency graph. R=brianwilkerson@google.com Committed: https://code.google.com/p/dart/source/detail?r=45611

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+245 lines, -347 lines) Patch
M pkg/analyzer/lib/src/generated/constant.dart View 19 chunks +173 lines, -226 lines 0 comments Download
M pkg/analyzer/lib/src/generated/element.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analyzer/test/generated/all_the_rest_test.dart View 7 chunks +71 lines, -120 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
Paul Berry
5 years, 7 months ago (2015-05-07 17:45:32 UTC) #2
Brian Wilkerson
LGTM
5 years, 7 months ago (2015-05-07 18:34:45 UTC) #3
Paul Berry
5 years, 7 months ago (2015-05-07 19:38:51 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as 45611 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698