Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(380)

Issue 1128903012: dart2js cps: Fix for try/catch. (Closed)

Created:
5 years, 7 months ago by asgerf
Modified:
5 years, 7 months ago
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 2

Patch Set 2 : Status file #

Total comments: 1

Patch Set 3 : Stray status file update from another CL #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -4 lines) Patch
M pkg/compiler/lib/src/cps_ir/cps_ir_builder.dart View 1 2 3 chunks +6 lines, -1 line 0 comments Download
M tests/language/language_dart2js.status View 1 2 2 chunks +0 lines, -3 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
asgerf
https://codereview.chromium.org/1128903012/diff/1/pkg/compiler/lib/src/cps_ir/cps_ir_builder.dart File pkg/compiler/lib/src/cps_ir/cps_ir_builder.dart (right): https://codereview.chromium.org/1128903012/diff/1/pkg/compiler/lib/src/cps_ir/cps_ir_builder.dart#newcode1870 pkg/compiler/lib/src/cps_ir/cps_ir_builder.dart:1870: catchContinuation.body = catchBuilder._root; The fragment in catchBuilder was previously ...
5 years, 7 months ago (2015-05-19 09:54:55 UTC) #2
asgerf
https://codereview.chromium.org/1128903012/diff/20001/tests/language/language_dart2js.status File tests/language/language_dart2js.status (right): https://codereview.chromium.org/1128903012/diff/20001/tests/language/language_dart2js.status#newcode1061 tests/language/language_dart2js.status:1061: issue9939_test : Crash # The null object does not ...
5 years, 7 months ago (2015-05-19 10:30:44 UTC) #3
Kevin Millikin (Google)
LGTM.
5 years, 7 months ago (2015-05-20 07:55:13 UTC) #4
asgerf
5 years, 7 months ago (2015-05-20 08:57:11 UTC) #5
Message was sent while issue was closed.
Committed patchset #3 (id:40001) manually as
5f2726b451f2b3153942756f5216f337e764bc45 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698