Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(65)

Issue 1128873011: Add handling of HTTP '100 Continue' intermediate response (Closed)

Created:
5 years, 7 months ago by Søren Gjesse
Modified:
5 years, 7 months ago
Reviewers:
kustermann
CC:
reviews_dartlang.org
Target Ref:
refs/remotes/git-svn
Visibility:
Public.

Description

Add handling of HTTP '100 Continue' intermediate response The '100 Continue' intermediate response is just ignored, as there is currently no API for the client to wait to this. BUG=http://dartbug.com/23413 R=kustermann@google.com Committed: https://code.google.com/p/dart/source/detail?r=45685

Patch Set 1 #

Total comments: 2

Patch Set 2 : Addressed review comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+91 lines, -2 lines) Patch
M sdk/lib/io/http_impl.dart View 1 1 chunk +18 lines, -2 lines 0 comments Download
A tests/standalone/io/http_100_continue.dart View 1 chunk +73 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
Søren Gjesse
5 years, 7 months ago (2015-05-11 12:24:58 UTC) #2
kustermann
lgtm https://codereview.chromium.org/1128873011/diff/1/sdk/lib/io/http_impl.dart File sdk/lib/io/http_impl.dart (right): https://codereview.chromium.org/1128873011/diff/1/sdk/lib/io/http_impl.dart#newcode1302 sdk/lib/io/http_impl.dart:1302: new HttpException(error.message, uri: _currentUri), indentation
5 years, 7 months ago (2015-05-11 12:51:41 UTC) #3
Søren Gjesse
As discussed offline also tested it with a node.js server (which supports requests with 'Expect: ...
5 years, 7 months ago (2015-05-11 13:41:13 UTC) #4
Søren Gjesse
5 years, 7 months ago (2015-05-11 13:48:22 UTC) #5
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as 45685 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698