Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(34)

Issue 1128833003: check for package lib exist before making package suggestions (Closed)

Created:
5 years, 7 months ago by danrubel
Modified:
5 years, 7 months ago
Reviewers:
scheglov
CC:
reviews_dartlang.org
Target Ref:
refs/remotes/git-svn
Visibility:
Public.

Description

check for package lib exist before making package suggestions BUG=dartbug.com/23428 R=scheglov@google.com Committed: https://code.google.com/p/dart/source/detail?r=45706

Patch Set 1 #

Patch Set 2 : merge #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -1 line) Patch
M pkg/analysis_server/lib/src/services/completion/import_uri_contributor.dart View 1 chunk +3 lines, -1 line 0 comments Download
M pkg/analysis_server/test/services/completion/import_uri_contributor_test.dart View 1 chunk +12 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
danrubel
5 years, 7 months ago (2015-05-11 18:38:55 UTC) #2
scheglov
LGTM
5 years, 7 months ago (2015-05-11 18:40:50 UTC) #3
danrubel
5 years, 7 months ago (2015-05-11 18:48:22 UTC) #4
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as 45706 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698