Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(128)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1128183004: Stop using pkg/matcher in JSON pretty test (Closed)

Created:
5 years, 7 months ago by kevmoo
Modified:
5 years, 7 months ago
CC:
reviews_dartlang.org, Lasse Reichstein Nielsen
Target Ref:
refs/remotes/git-svn
Visibility:
Public.

Description

Stop using pkg/matcher in JSON pretty test R=nweiz@google.com Committed: https://code.google.com/p/dart/source/detail?r=45656

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -6 lines) Patch
M tests/lib/convert/json_pretty_test.dart View 3 chunks +6 lines, -6 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
kevmoo
5 years, 7 months ago (2015-05-08 20:52:15 UTC) #2
nweiz
lgtm, but please cc whoever's maintaining dart:collection as well
5 years, 7 months ago (2015-05-08 20:53:13 UTC) #3
kevmoo
Adding Lasse, who has been maintaining convert
5 years, 7 months ago (2015-05-08 20:55:36 UTC) #4
kevmoo
Adding Lasse, who has been maintaining convert
5 years, 7 months ago (2015-05-08 20:55:39 UTC) #5
kevmoo
Committed patchset #1 (id:1) manually as 45656 (presubmit successful).
5 years, 7 months ago (2015-05-08 20:56:00 UTC) #6
Lasse Reichstein Nielsen
5 years, 7 months ago (2015-05-08 23:10:40 UTC) #8
Message was sent while issue was closed. 
lgtm

Powered by Google App Engine
This is Rietveld 408576698