Issue 11280241: Fix StringBase_createFromCodePoints to correctly accept Latin-1 characters

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 11280241: Fix StringBase_createFromCodePoints to correctly accept Latin-1 characters (Closed)

Created:
8 years ago by siva

Modified:
8 years ago

Reviewers:
Anton Muhin, srdjan, cshapiro

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/runtime/

Visibility:
Public.

More Reviews

Description

Fix StringBase_createFromCodePoints to correctly accept Latin-1 characters as one_byte_string. Rename Dart_NewExternalUTF8String to Dart_NewExternalLatin1String, this reflects the functionality correctly. Committed: https://code.google.com/p/dart/source/detail?r=15554

Patch Set 1 #

Total comments: 2

Patch Set 2 : #

Created: 8 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+28 lines, -27 lines)			Patch
M	include/dart_api.h	View		2 chunks	+8 lines, -7 lines	0 comments	Download
M	lib/string.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	vm/benchmark_test.cc	View		1 chunk	+2 lines, -4 lines	0 comments	Download
M	vm/dart_api_impl.cc	View		1 chunk	+8 lines, -7 lines	0 comments	Download
M	vm/dart_api_impl_test.cc	View	1	5 chunks	+9 lines, -8 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

srdjan

dbc https://codereview.chromium.org/11280241/diff/1/vm/dart_api_impl_test.cc File vm/dart_api_impl_test.cc (right): https://codereview.chromium.org/11280241/diff/1/vm/dart_api_impl_test.cc#newcode516 vm/dart_api_impl_test.cc:516: uint8_t data8[] = { 'o', 'n', 'e', 0x7F ...

8 years ago (2012-11-29 21:05:51 UTC) #3

siva

https://codereview.chromium.org/11280241/diff/1/vm/dart_api_impl_test.cc File vm/dart_api_impl_test.cc (right): https://codereview.chromium.org/11280241/diff/1/vm/dart_api_impl_test.cc#newcode516 vm/dart_api_impl_test.cc:516: uint8_t data8[] = { 'o', 'n', 'e', 0x7F }; ...

8 years ago (2012-11-29 23:20:41 UTC) #4

Message was sent while issue was closed.

lgtm

Expand Messages | Collapse Messages