Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(156)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 11280238: Add ability to publish package without a pubspec. (Closed)

Created:
8 years ago by dgrove
Modified:
8 years ago
Reviewers:
Bob Nystrom
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Add ability to publish package without a pubspec. Committed: https://code.google.com/p/dart/source/detail?r=15544

Patch Set 1 #

Patch Set 2 : #

Total comments: 6

Patch Set 3 : #

Patch Set 4 : #

Patch Set 5 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+59 lines, -18 lines) Patch
M tools/publish_pkg.py View 1 2 3 4 4 chunks +59 lines, -18 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
dgrove
8 years ago (2012-11-29 17:22:30 UTC) #1
Bob Nystrom
https://codereview.chromium.org/11280238/diff/2001/tools/publish_pkg.py File tools/publish_pkg.py (right): https://codereview.chromium.org/11280238/diff/2001/tools/publish_pkg.py#newcode70 tools/publish_pkg.py:70: pubspecFile = open(pubspec) How about: with open(pubspec) as pubspecFile: ...
8 years ago (2012-11-29 17:28:14 UTC) #2
dgrove
https://codereview.chromium.org/11280238/diff/2001/tools/publish_pkg.py File tools/publish_pkg.py (right): https://codereview.chromium.org/11280238/diff/2001/tools/publish_pkg.py#newcode70 tools/publish_pkg.py:70: pubspecFile = open(pubspec) On 2012/11/29 17:28:14, Bob Nystrom wrote: ...
8 years ago (2012-11-29 18:45:30 UTC) #3
Bob Nystrom
8 years ago (2012-11-29 18:48:54 UTC) #4 
LGTM

Powered by Google App Engine
This is Rietveld 408576698