Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(343)

Issue 11280232: Implement better side effect tracking for load-to-load forwarding. (Closed)

Created:
8 years ago by Vyacheslav Egorov (Google)
Modified:
8 years ago
Reviewers:
Florian Schneider
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Implement better side effect tracking for load-to-load forwarding. Any field store can interfere only with stores to the same offset. Indexed store can only interfere with indexed load. This tracking is not yet used by LICM. R=fschneider@google.com BUG= Committed: https://code.google.com/p/dart/source/detail?r=15518

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+108 lines, -11 lines) Patch
M runtime/vm/flow_graph_optimizer.cc View 10 chunks +108 lines, -11 lines 1 comment Download

Messages

Total messages: 2 (0 generated)
Vyacheslav Egorov (Google)
8 years ago (2012-11-29 13:15:15 UTC) #1
Florian Schneider
8 years ago (2012-11-29 13:42:48 UTC) #2
LGTM.

Please add a test for both cases  (field and indexed loads).

https://codereview.chromium.org/11280232/diff/1/runtime/vm/flow_graph_optimiz...
File runtime/vm/flow_graph_optimizer.cc (right):

https://codereview.chromium.org/11280232/diff/1/runtime/vm/flow_graph_optimiz...
runtime/vm/flow_graph_optimizer.cc:2997: }
Maybe continue already here since IsInterferingStore implies 
IsLoadEliminatationCandidate(instr).

ASSERT(!IsLoadEliminationCandidate(instr))
continue;

Powered by Google App Engine
This is Rietveld 408576698