Optimize checked mode asserts with uninstantiated types and known constant type-arguments.

Instantiate uninstantiated types with known constant type-arguments.

The enables eliminating more type-checks.

For type-checks that have a uninstantiated target type and a constant
instantiator type arguments as input, we can instantiate the type
at compile-time.
Committed: https://code.google.com/p/dart/source/detail?r=15689

[regis, 2012-11-29 16:25:19]

LGTM

https://codereview.chromium.org/11280230/diff/1/runtime/vm/intermediate_langu...
File runtime/vm/intermediate_language.cc (right):

https://codereview.chromium.org/11280230/diff/1/runtime/vm/intermediate_langu...
runtime/vm/intermediate_language.cc:1510: (check->dst_type().Canonicalize() ==
dst_type().Canonicalize())) {
Aren't the types canonicalized already? It may be worth asserting that they are
and fix the code upstream if they are not.

https://codereview.chromium.org/11280230/diff/1/runtime/vm/intermediate_langu...
runtime/vm/intermediate_language.cc:1528:
dst_type().InstantiateFrom(instantiator_type_args));
You should canonicalize new_dst_type here.

[Florian Schneider, 2012-12-04 14:48:04]

https://codereview.chromium.org/11280230/diff/1/runtime/vm/intermediate_langu...
File runtime/vm/intermediate_language.cc (right):

https://codereview.chromium.org/11280230/diff/1/runtime/vm/intermediate_langu...
runtime/vm/intermediate_language.cc:1510: (check->dst_type().Canonicalize() ==
dst_type().Canonicalize())) {
On 2012/11/29 16:25:19, regis wrote:
> Aren't the types canonicalized already? It may be worth asserting that they
are
> and fix the code upstream if they are not.

They are not all canonicalized. For now, I'm using Equals instead of comparing
raw objects.

https://codereview.chromium.org/11280230/diff/1/runtime/vm/intermediate_langu...
runtime/vm/intermediate_language.cc:1528:
dst_type().InstantiateFrom(instantiator_type_args));
On 2012/11/29 16:25:19, regis wrote:
> You should canonicalize new_dst_type here.

Done.

[regis, 2012-12-05 19:08:02]

https://codereview.chromium.org/11280230/diff/1/runtime/vm/intermediate_langu...
File runtime/vm/intermediate_language.cc (right):

https://codereview.chromium.org/11280230/diff/1/runtime/vm/intermediate_langu...
runtime/vm/intermediate_language.cc:1510: (check->dst_type().Canonicalize() ==
dst_type().Canonicalize())) {
On 2012/12/04 14:48:04, Florian Schneider wrote:
> On 2012/11/29 16:25:19, regis wrote:
> > Aren't the types canonicalized already? It may be worth asserting that they
> are
> > and fix the code upstream if they are not.
> 
> They are not all canonicalized. For now, I'm using Equals instead of comparing
> raw objects. 
> 

"For now"? Please add a TODO.
Why are they not canonicalized? That was my first question. We need to
understand why and canonicalize them or explain in a comment under what
circumstances they are not canonicalized.