Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(443)

Issue 11280162: Add onError to dart:io SecureSocket. Allow onConnect and outputStream to coexist on Socket and Sec… (Closed)

Created:
8 years ago by Bill Hesse
Modified:
8 years ago
Reviewers:
Søren Gjesse
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Add onError to dart:io SecureSocket. Allow onConnect and outputStream to coexist on Socket and SecureSocket. BUG= Committed: https://code.google.com/p/dart/source/detail?r=15378

Patch Set 1 #

Patch Set 2 : Fix typo. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+46 lines, -14 lines) Patch
M runtime/bin/secure_socket.cc View 1 chunk +5 lines, -0 lines 0 comments Download
M runtime/bin/socket_patch.dart View 2 chunks +1 line, -5 lines 0 comments Download
M sdk/lib/io/secure_socket.dart View 1 8 chunks +40 lines, -9 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Bill Hesse
8 years ago (2012-11-26 17:45:24 UTC) #1
Søren Gjesse
8 years ago (2012-11-27 09:35:32 UTC) #2
lgtm

Powered by Google App Engine
This is Rietveld 408576698