Issue 11280155: Issue 6908. Fix parsing look for receiver.() in switch.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 11280155: Issue 6908. Fix parsing look for receiver.() in switch. (Closed)

Created:
8 years ago by scheglov

Modified:
8 years ago

Reviewers:
Brian Wilkerson

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Issue 6908. Fix parsing look for receiver.() in switch. http://code.google.com/p/dart/issues/detail?id=6908 R=brianwilkerson@google.com BUG= Committed: https://code.google.com/p/dart/source/detail?r=15336

Patch Set 1 #

Total comments: 1

Created: 8 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+40 lines, -0 lines)			Patch
	M	compiler/java/com/google/dart/compiler/parser/DartParser.java	View		1 chunk	+15 lines, -0 lines	1 comment	Download
	M	compiler/javatests/com/google/dart/compiler/parser/SyntaxTest.java	View		2 chunks	+25 lines, -0 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Brian Wilkerson

8 years ago (2012-11-26 15:47:58 UTC) #2

LGTM

https://codereview.chromium.org/11280155/diff/1/compiler/java/com/google/dart...
File compiler/java/com/google/dart/compiler/parser/DartParser.java (right):

https://codereview.chromium.org/11280155/diff/1/compiler/java/com/google/dart...
compiler/java/com/google/dart/compiler/parser/DartParser.java:3850:
beginIdentifier();
nit: This would be cleaner code if it were not inside a block.

Expand Messages | Collapse Messages