Issue 11280141: Be spec compliant. Fix issue 6870.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 11280141: Be spec compliant. Fix issue 6870. (Closed)

Created:
8 years, 1 month ago by ngeoffray

Modified:
8 years, 1 month ago

Reviewers:
ahe

CC:
reviews_dartlang.org, scheglov

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

Be spec compliant. Fix issue 6870. Committed: https://code.google.com/p/dart/source/detail?r=15248

Patch Set 2 : #

Created: 8 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -4 lines)			Patch
	M	sdk/lib/_internal/compiler/implementation/world.dart	View	1	1 chunk	+3 lines, -4 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

ahe

LGTM! https://codereview.chromium.org/11280141/diff/1/sdk/lib/_internal/compiler/implementation/world.dart File sdk/lib/_internal/compiler/implementation/world.dart (right): https://codereview.chromium.org/11280141/diff/1/sdk/lib/_internal/compiler/implementation/world.dart#newcode129 sdk/lib/_internal/compiler/implementation/world.dart:129: Set<ClassElement> types = typesImplementedBySubclasses[superclass]; types -> subclasses?

8 years, 1 month ago (2012-11-22 12:16:22 UTC) #2

ngeoffray

8 years, 1 month ago (2012-11-22 12:19:13 UTC) #3

Thanks Peter.

https://codereview.chromium.org/11280141/diff/1/sdk/lib/_internal/compiler/im...
File sdk/lib/_internal/compiler/implementation/world.dart (right):

https://codereview.chromium.org/11280141/diff/1/sdk/lib/_internal/compiler/im...
sdk/lib/_internal/compiler/implementation/world.dart:129: Set<ClassElement>
types = typesImplementedBySubclasses[superclass];
On 2012/11/22 12:16:23, ahe wrote:
> types -> subclasses?

Done.

Expand Messages | Collapse Messages

Issue 11280141: Be spec compliant. Fix issue 6870. (Closed)

Description

Patch Set 1 #

Patch Set 2 : #

Messages