Issue 11280135: Issue 6836. Using undeclared identifier in static context is now warning.

Issue 11280135: Issue 6836. Using undeclared identifier in static context is now warning. (Closed)

Created:
8 years, 1 month ago by scheglov

Modified:
8 years ago

Reviewers:
Brian Wilkerson

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Issue 6836. Using undeclared identifier in static context is now warning. http://code.google.com/p/dart/issues/detail?id=6836 R=brianwilkerson@google.com BUG= Committed: https://code.google.com/p/dart/source/detail?r=15311

Patch Set 1 #

Total comments: 1

Created: 8 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+137 lines, -54 lines)			Patch
M	compiler/java/com/google/dart/compiler/parser/DartParser.java	View	3 chunks	+5 lines, -0 lines	0 comments	Download
M	compiler/java/com/google/dart/compiler/parser/ParserErrorCode.java	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	compiler/java/com/google/dart/compiler/resolver/Elements.java	View	1 chunk	+8 lines, -0 lines	0 comments	Download
M	compiler/java/com/google/dart/compiler/resolver/Resolver.java	View	3 chunks	+49 lines, -7 lines	0 comments	Download
M	compiler/java/com/google/dart/compiler/resolver/ResolverErrorCode.java	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	compiler/javatests/com/google/dart/compiler/parser/SyntaxTest.java	View	1 chunk	+8 lines, -0 lines	0 comments	Download
M	compiler/javatests/com/google/dart/compiler/resolver/NegativeResolverTest.java	View	1 chunk	+1 line, -1 line	0 comments	Download
M	compiler/javatests/com/google/dart/compiler/resolver/ResolverTest.java	View	1 chunk	+1 line, -1 line	0 comments	Download
M	compiler/javatests/com/google/dart/compiler/type/TypeAnalyzerCompilerTest.java	View	3 chunks	+23 lines, -6 lines	0 comments	Download
M	editor/tools/plugins/com.google.dart.tools.ui/src/com/google/dart/tools/ui/internal/text/correction/QuickFixProcessor.java	View	9 chunks	+16 lines, -8 lines	1 comment	Download
M	pkg/intl/lib/src/http_request_data_reader.dart	View	1 chunk	+1 line, -1 line	0 comments	Download
M	tests/co19/co19-compiler.status	View	5 chunks	+8 lines, -25 lines	0 comments	Download
M	tests/corelib/map_from_test.dart	View	1 chunk	+3 lines, -3 lines	0 comments	Download
M	tests/language/language.status	View	2 chunks	+7 lines, -2 lines	0 comments	Download
M	tests/utils/utils.status	View	1 chunk	+5 lines, -0 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Brian Wilkerson

8 years ago (2012-11-26 14:40:40 UTC) #2

LGTM

https://codereview.chromium.org/11280135/diff/1/editor/tools/plugins/com.goog...
File
editor/tools/plugins/com.google.dart.tools.ui/src/com/google/dart/tools/ui/internal/text/correction/QuickFixProcessor.java
(right):

https://codereview.chromium.org/11280135/diff/1/editor/tools/plugins/com.goog...
editor/tools/plugins/com.google.dart.tools.ui/src/com/google/dart/tools/ui/internal/text/correction/QuickFixProcessor.java:265:
System.out.println(errorCode);
nit: if it's useful to keep these lines, they should be converted to write to
the log file.

Expand Messages | Collapse Messages