Issue 11280122: Do not type check parameters that are not passed directly.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 11280122: Do not type check parameters that are not passed directly. (Closed)

Created:
8 years, 1 month ago by ngeoffray

Modified:
8 years, 1 month ago

Reviewers:
floitsch

CC:
reviews_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

Do not type check parameters that are not passed directly. Committed: https://code.google.com/p/dart/source/detail?r=15206

Patch Set 1 : #

Created: 8 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+15 lines, -4 lines)			Patch
	M	sdk/lib/_internal/compiler/implementation/ssa/builder.dart	View		1 chunk	+15 lines, -4 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

floitsch

LGTM, but iirc this looks like a code duplication. cleanup in follow-up CL?

8 years, 1 month ago (2012-11-21 16:22:45 UTC) #3

ngeoffray

8 years, 1 month ago (2012-11-21 16:25:37 UTC) #4

On 2012/11/21 16:22:45, floitsch wrote:
> LGTM, but iirc this looks like a code duplication.
> cleanup in follow-up CL?

Yes. The reason I did not change it is because I'd like to use the isBox method
but it requires to have setup things already. I'll clean that up.

Expand Messages | Collapse Messages