Issue 11280077: Removed Window.focus and Window.blur as they are no longer recommended.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 11280077: Removed Window.focus and Window.blur as they are no longer recommended. (Closed)

Created:
8 years, 1 month ago by Andrei Mouravski

Modified:
8 years, 1 month ago

Reviewers:
blois

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Removed Window.focus and Window.blur as they are no longer recommended. See: dev.w3.org/html5/spec/editing.html#document-level-focus-apis Committed: https://code.google.com/p/dart/source/detail?r=15131

Patch Set 1 #

Total comments: 1

Patch Set 2 : Removed from localwindow, too. #

Created: 8 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -20 lines)			Patch
M	sdk/lib/html/dart2js/html_dart2js.dart	View	1	3 chunks	+0 lines, -8 lines	0 comments	Download
M	sdk/lib/html/dartium/html_dartium.dart	View		3 chunks	+0 lines, -10 lines	0 comments	Download
M	sdk/lib/html/scripts/htmlrenamer.py	View	1	1 chunk	+2 lines, -0 lines	0 comments	Download
M	sdk/lib/html/src/CrossFrameTypes.dart	View		1 chunk	+0 lines, -2 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Andrei Mouravski

Sorry for all the CLs! Thanks for reviewing them!

8 years, 1 month ago (2012-11-20 00:16:38 UTC) #1

blois

http://codereview.chromium.org/11280077/diff/1/sdk/lib/html/src/CrossFrameTypes.dart File sdk/lib/html/src/CrossFrameTypes.dart (left): http://codereview.chromium.org/11280077/diff/1/sdk/lib/html/src/CrossFrameTypes.dart#oldcode35 sdk/lib/html/src/CrossFrameTypes.dart:35: void blur(); I believe that LocalWindow still has blur ...

8 years, 1 month ago (2012-11-20 00:24:31 UTC) #2

lgtm

Expand Messages | Collapse Messages