Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(544)

Issue 11280059: Always zero-initialize array used for mapping VM symbols to Dart_CObject (Closed)

Created:
8 years, 1 month ago by Søren Gjesse
Modified:
8 years, 1 month ago
Reviewers:
Mads Ager (google)
CC:
reviews_dartlang.org, cshapiro, Florian Schneider
Visibility:
Public.

Description

Always zero-initialize array used for mapping VM symbols to Dart_CObject NULL pointer checks are used to check for valid entries. TBR=ager@google.com BUG= Committed: https://code.google.com/p/dart/source/detail?r=15086

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -2 lines) Patch
M runtime/vm/dart_api_message.cc View 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Søren Gjesse
8 years, 1 month ago (2012-11-19 14:58:58 UTC) #1
Mads Ager (google)
8 years, 1 month ago (2012-11-19 15:03:23 UTC) #2
LGTM, thanks for spotting this Florian.

Powered by Google App Engine
This is Rietveld 408576698