Issue 11280034: Move more methods to the new interceptor scheme

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 11280034: Move more methods to the new interceptor scheme (Closed)

Created:
8 years, 1 month ago by ngeoffray

Modified:
8 years, 1 month ago

Reviewers:
ahe, karlklose

CC:
reviews_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

Move more methods to the new interceptor scheme, and support having the same method in two intercepted classes. Committed: https://code.google.com/p/dart/source/detail?r=15078

Created: 8 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+129 lines, -210 lines)			Patch
M	sdk/lib/_internal/compiler/implementation/lib/interceptors.dart	View	1	4 chunks	+7 lines, -209 lines	0 comments	Download
M	sdk/lib/_internal/compiler/implementation/lib/js_array.dart	View	1 2 3	1 chunk	+80 lines, -0 lines	0 comments	Download
M	sdk/lib/_internal/compiler/implementation/lib/js_string.dart	View	1	1 chunk	+31 lines, -0 lines	0 comments	Download
M	sdk/lib/_internal/compiler/implementation/ssa/builder.dart	View	1	1 chunk	+9 lines, -1 line	0 comments	Download
M	tests/corelib/string_test.dart	View	1	1 chunk	+2 lines, -0 lines	0 comments	Download

Total messages: 3 (0 generated)

ngeoffray

8 years, 1 month ago (2012-11-19 13:22:38 UTC) #3

Thanks Karl. As discussed, I added new tests in the string test file because I
hit a problem when porting the interceptors that was hard to find.