Issue 1127863002: Don't let the version solver starve the event queue.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1127863002: Don't let the version solver starve the event queue. (Closed)

Created:
5 years, 7 months ago by nweiz

Modified:
5 years, 7 months ago

Reviewers:
Bob Nystrom

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Target Ref:
refs/remotes/git-svn

Visibility:
Public.

More Reviews

Description

Don't let the version solver starve the event queue. R=rnystrom@google.com Committed: https://code.google.com/p/dart/source/detail?r=45543

Patch Set 2 : Code review changes #

Created: 5 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+13 lines, -14 lines)			Patch
	M	sdk/lib/_internal/pub/lib/src/solver/backtracking_solver.dart	View	1	1 chunk	+13 lines, -14 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Bob Nystrom

lgtm https://codereview.chromium.org/1127863002/diff/1/sdk/lib/_internal/pub/lib/src/solver/backtracking_solver.dart File sdk/lib/_internal/pub/lib/src/solver/backtracking_solver.dart (right): https://codereview.chromium.org/1127863002/diff/1/sdk/lib/_internal/pub/lib/src/solver/backtracking_solver.dart#newcode261 sdk/lib/_internal/pub/lib/src/solver/backtracking_solver.dart:261: if (!(await _backtrack(error))) rethrow; How about re-adding that ...

5 years, 7 months ago (2015-05-05 22:11:55 UTC) #2

nweiz

5 years, 7 months ago (2015-05-05 22:54:51 UTC) #4

Message was sent while issue was closed.

Committed patchset #2 (id:20001) manually as 45543 (presubmit successful).

Expand Messages | Collapse Messages

Issue 1127863002: Don't let the version solver starve the event queue. (Closed)

Description

Patch Set 1 #

Patch Set 2 : Code review changes #

Messages