suggest only superclass elements for "super."

suggest only superclass elements for "super."

BUG=dartbug.com/23208
R=paulberry@google.com

Committed: https://code.google.com/p/dart/source/detail?r=45535

[danrubel, 2015-05-05 01:46:46]

danrubel@google.com changed reviewers:
+ paulberry@google.com

[Paul Berry, 2015-05-05 02:41:28]

lgtm assuming issue below is addressed.

Also, consider rephrasing the commit message, since what we're doing is not
filtering the suggestions but filtering the types which will be searched for
possible completions.

https://codereview.chromium.org/1127643003/diff/20001/pkg/analysis_server/lib...
File pkg/analysis_server/lib/src/services/completion/suggestion_builder.dart
(right):

https://codereview.chromium.org/1127643003/diff/20001/pkg/analysis_server/lib...
pkg/analysis_server/lib/src/services/completion/suggestion_builder.dart:356: //
Do not suggest members from the target type if the target is "super"
If the target is "super", then members from interfaces shouldn't be suggested
either, e.g.:

class B {
  foo() {}
}
class I {
  bar() {}
}
class C extends B implements I {
  baz() {
    super.^
  }
}

should not show bar() as a suggestion, since super can't be used to call methods
defined in interfaces.  (Note that the analyzer's resolution engine currently
gets this wrong--see dartbug.com/23380)

[danrubel, 2015-05-05 19:10:03]

Committed patchset #4 (id:60001) manually as 45535 (presubmit successful).

[danrubel, 2015-05-05 20:03:18]

https://codereview.chromium.org/1127643003/diff/20001/pkg/analysis_server/lib...
File pkg/analysis_server/lib/src/services/completion/suggestion_builder.dart
(right):

https://codereview.chromium.org/1127643003/diff/20001/pkg/analysis_server/lib...
pkg/analysis_server/lib/src/services/completion/suggestion_builder.dart:356: //
Do not suggest members from the target type if the target is "super"
On 2015/05/05 02:41:27, Paul Berry wrote:
> If the target is "super", then members from interfaces shouldn't be suggested
> either, e.g.:
> 
> class B {
>   foo() {}
> }
> class I {
>   bar() {}
> }
> class C extends B implements I {
>   baz() {
>     super.^
>   }
> }
> 
> should not show bar() as a suggestion, since super can't be used to call
methods
> defined in interfaces.  (Note that the analyzer's resolution engine currently
> gets this wrong--see dartbug.com/23380)

Great point. Fixed.