Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(27)

Issue 11276022: Avoid integer overflow when computing the size of new space in bytes. (Closed)

Created:
8 years, 1 month ago by cshapiro
Modified:
8 years, 1 month ago
Reviewers:
siva
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Visibility:
Public.

Description

Avoid integer overflow when computing the size of new space in bytes. Committed: https://code.google.com/p/dart/source/detail?r=14118

Patch Set 1 #

Patch Set 2 : address review comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -4 lines) Patch
M runtime/platform/globals.h View 1 1 chunk +3 lines, -3 lines 0 comments Download
M runtime/vm/heap.cc View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 2 (0 generated)
cshapiro
8 years, 1 month ago (2012-10-25 04:27:37 UTC) #1
siva
8 years, 1 month ago (2012-10-25 21:03:48 UTC) #2
as discussed offline we will make KB, MB and GB intptr_t values.

LGTM

Powered by Google App Engine
This is Rietveld 408576698