Issue 11275313: Move JsString into its own file.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 11275313: Move JsString into its own file. (Closed)

Created:
8 years, 1 month ago by ngeoffray

Modified:
8 years, 1 month ago

Reviewers:
ahe

CC:
reviews_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

Move JsString into its own file. Committed: https://code.google.com/p/dart/source/detail?r=14899

Patch Set 2 : #

Created: 8 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -676 lines)			Patch
	M	sdk/lib/_internal/compiler/implementation/lib/interceptors.dart	View	1	1 chunk	+3 lines, -92 lines	0 comments	Download
	A +	sdk/lib/_internal/compiler/implementation/lib/js_string.dart	View	1	2 chunks	+1 line, -584 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

ahe

LGTM! Thanks for making the diff so easy to read. https://codereview.chromium.org/11275313/diff/1/sdk/lib/_internal/compiler/implementation/lib/interceptors.dart File sdk/lib/_internal/compiler/implementation/lib/interceptors.dart (right): https://codereview.chromium.org/11275313/diff/1/sdk/lib/_internal/compiler/implementation/lib/interceptors.dart#newcode5 ...

8 years, 1 month ago (2012-11-14 14:41:09 UTC) #2

ngeoffray

8 years, 1 month ago (2012-11-14 16:13:11 UTC) #3

Thanks Peter

https://codereview.chromium.org/11275313/diff/1/sdk/lib/_internal/compiler/im...
File sdk/lib/_internal/compiler/implementation/lib/interceptors.dart (right):

https://codereview.chromium.org/11275313/diff/1/sdk/lib/_internal/compiler/im...
sdk/lib/_internal/compiler/implementation/lib/interceptors.dart:5:
#library('dart:_interceptors');
On 2012/11/14 14:41:09, ahe wrote:
> Could you update the library syntax now you're touching it anyways?

Done.

https://codereview.chromium.org/11275313/diff/1/sdk/lib/_internal/compiler/im...
File sdk/lib/_internal/compiler/implementation/lib/js_string.dart (right):

https://codereview.chromium.org/11275313/diff/1/sdk/lib/_internal/compiler/im...
sdk/lib/_internal/compiler/implementation/lib/js_string.dart:4: 
On 2012/11/14 14:41:09, ahe wrote:
> part of ....

Done.

Expand Messages | Collapse Messages

Issue 11275313: Move JsString into its own file. (Closed)

Description

Patch Set 1 #

Patch Set 2 : #

Messages