Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(22)

Issue 11275227: dart2js: Added support for writing dependency information into a file. (Closed)

Created:
8 years, 1 month ago by kustermann
Modified:
8 years, 1 month ago
Reviewers:
ricow1, ahe
CC:
reviews_dartlang.org
Visibility:
Public.

Description

dart2js: Added support for writing dependency information into a file. Having a way to detect if a dart application was modified is very useful. In particular the test infrastructure can use it to reduce redundant dart2js compilations. In order to do that, the dependencies of the dart application are needed. The added code will write the dependency information to a '*.js.deps' file. Committed: https://code.google.com/p/dart/source/detail?r=14780

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -0 lines) Patch
M sdk/lib/_internal/compiler/implementation/dart2js.dart View 1 2 chunks +7 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
kustermann
8 years, 1 month ago (2012-11-09 13:37:02 UTC) #1
ahe
Clean and simple, LGTM Consider sorting the file names.
8 years, 1 month ago (2012-11-09 14:48:10 UTC) #2
ricow1
LGTM, I agree with Peter, having it sorted is nicer if a human is reading ...
8 years, 1 month ago (2012-11-12 07:23:04 UTC) #3
kustermann
PTAL
8 years, 1 month ago (2012-11-12 08:06:07 UTC) #4
ahe
8 years, 1 month ago (2012-11-12 08:27:44 UTC) #5
LGTM

Powered by Google App Engine
This is Rietveld 408576698