Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(86)

Issue 11275207: Test case for issue 6108 (Closed)

Created:
8 years, 1 month ago by siva
Modified:
8 years, 1 month ago
Reviewers:
Ivan Posva
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Test case for issue 6108 Committed: https://code.google.com/p/dart/source/detail?r=14979

Patch Set 1 #

Patch Set 2 : #

Total comments: 2

Patch Set 3 : #

Patch Set 4 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+32 lines, -0 lines) Patch
A isolate/illegal_msg_test.dart View 1 2 3 1 chunk +32 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
siva
8 years, 1 month ago (2012-11-08 02:29:00 UTC) #1
Ivan Posva
http://codereview.chromium.org/11275207/diff/2001/isolate/illegal_msg_negative_test.dart File isolate/illegal_msg_negative_test.dart (right): http://codereview.chromium.org/11275207/diff/2001/isolate/illegal_msg_negative_test.dart#newcode17 isolate/illegal_msg_negative_test.dart:17: snd.send(funcFoo, port.toSendPort()); The goal was to get away from ...
8 years, 1 month ago (2012-11-08 03:45:32 UTC) #2
siva
http://codereview.chromium.org/11275207/diff/2001/isolate/illegal_msg_negative_test.dart File isolate/illegal_msg_negative_test.dart (right): http://codereview.chromium.org/11275207/diff/2001/isolate/illegal_msg_negative_test.dart#newcode17 isolate/illegal_msg_negative_test.dart:17: snd.send(funcFoo, port.toSendPort()); Made it a positive test by catching ...
8 years, 1 month ago (2012-11-08 17:05:58 UTC) #3
Ivan Posva
8 years, 1 month ago (2012-11-08 18:58:10 UTC) #4
LGTM -ip

Powered by Google App Engine
This is Rietveld 408576698