Issue 11275150: Revert commit 14524, which builds NSS and NSPR libraries, for secure networking.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 11275150: Revert commit 14524, which builds NSS and NSPR libraries, for secure networking. (Closed)

Created:
8 years, 1 month ago by Bill Hesse

Modified:
8 years, 1 month ago

Reviewers:
Anton Muhin, Mads Ager (google)

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Revert commit 14524, which builds NSS and NSPR libraries, for secure networking. There are builders which build Windows 64-bit versions of the SDK, and the Dartium build builds the Dart runtime executable, both of which were not supported by the CL. BUG= Committed: https://code.google.com/p/dart/source/detail?r=14527

Patch Set 1 #

Created: 8 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+0 lines, -1903 lines)			Patch
M	runtime/bin/bin.gypi	View	2 chunks	+0 lines, -23 lines	0 comments	Download
D	runtime/bin/net/nss.gyp	View	1 chunk	+0 lines, -1262 lines	0 comments	Download
D	runtime/bin/net/os_linux.S	View	1 chunk	+0 lines, -11 lines	0 comments	Download
D	runtime/bin/net/sqlite.gyp	View	1 chunk	+0 lines, -203 lines	0 comments	Download
D	runtime/bin/net/ssl.gyp	View	1 chunk	+0 lines, -165 lines	0 comments	Download
D	runtime/bin/net/zlib.gyp	View	1 chunk	+0 lines, -167 lines	0 comments	Download
D	runtime/tools/gyp/nss_configurations.gypi	View	1 chunk	+0 lines, -72 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Mads Ager (google)

8 years, 1 month ago (2012-11-05 14:14:20 UTC) #2

LGTM :(

Anton, could you and Bill coordinate on getting rid of that dependency on
Dartium?

Expand Messages | Collapse Messages