Issue 11275125: Prevent hanging if selenium cannot close browser.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 11275125: Prevent hanging if selenium cannot close browser. (Closed)

Created:
8 years, 1 month ago by ahe

Modified:
8 years, 1 month ago

Reviewers:
ricow1, Emily Fortuna

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

Prevent hanging if selenium cannot close browser. Committed: https://code.google.com/p/dart/source/detail?r=14511

Created: 8 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+20 lines, -1 line)			Patch
	M	dart/tools/testing/run_selenium.py	View		2 chunks	+20 lines, -1 line	0 comments	Download

Total messages: 3 (0 generated)

ricow1

8 years, 1 month ago (2012-11-05 06:46:08 UTC) #3

LGTM with the already added parenthesis on the method definitions