Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(206)

Issue 11275122: Merge revision r14430 to trunk. Do not evaluate arguments of an instance send if that instance sen… (Closed)

Created:
8 years, 1 month ago by ngeoffray
Modified:
8 years, 1 month ago
Reviewers:
dgrove, kasperl
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Merge revision r14430 to trunk. Do not evaluate arguments of an instance send if that instance send is being inlined. The inliner will take care of evaluating them. Committed: https://code.google.com/p/dart/source/detail?r=14458

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -7 lines) Patch
M dart/lib/compiler/implementation/ssa/builder.dart View 2 chunks +7 lines, -7 lines 0 comments Download
A + dart/tests/language/inline_argument_test.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
M dart/tools/VERSION View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 2 (0 generated)
ngeoffray
8 years, 1 month ago (2012-11-02 09:09:02 UTC) #1
kasperl
8 years, 1 month ago (2012-11-02 09:10:28 UTC) #2
LGTM.

Powered by Google App Engine
This is Rietveld 408576698