Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(384)

Issue 11275098: Improve RangeBoundary::LowerBound/UpperBound. (Closed)

Created:
8 years, 1 month ago by Vyacheslav Egorov (Google)
Modified:
8 years, 1 month ago
Reviewers:
Florian Schneider
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Improve RangeBoundary::LowerBound/UpperBound. They should not just return MinSmi/MaxSmi when symbol's range is not available. Instead they should take offset into account. R=fschneider@google.com BUG= Committed: https://code.google.com/p/dart/source/detail?r=14426

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -4 lines) Patch
M runtime/vm/intermediate_language.cc View 2 chunks +12 lines, -4 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Vyacheslav Egorov (Google)
8 years, 1 month ago (2012-11-01 14:47:45 UTC) #1
Florian Schneider
8 years, 1 month ago (2012-11-01 18:17:22 UTC) #2
lgtm

Powered by Google App Engine
This is Rietveld 408576698