Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(110)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1127483002: More fixes to the new analysis context implementation (Closed)

Created:
5 years, 7 months ago by Brian Wilkerson
Modified:
5 years, 7 months ago
Reviewers:
scheglov
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

More fixes to the new analysis context implementation R=scheglov@google.com Committed: https://code.google.com/p/dart/source/detail?r=45479

Patch Set 1 #

Total comments: 2

Patch Set 2 : Address comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+292 lines, -101 lines) Patch
M pkg/analyzer/lib/src/context/cache.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analyzer/lib/src/context/context.dart View 1 24 chunks +237 lines, -54 lines 0 comments Download
M pkg/analyzer/test/src/context/context_test.dart View 21 chunks +54 lines, -46 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
Brian Wilkerson
5 years, 7 months ago (2015-05-02 15:45:21 UTC) #2
scheglov
LGTM https://codereview.chromium.org/1127483002/diff/1/pkg/analyzer/lib/src/context/context.dart File pkg/analyzer/lib/src/context/context.dart (right): https://codereview.chromium.org/1127483002/diff/1/pkg/analyzer/lib/src/context/context.dart#newcode100 pkg/analyzer/lib/src/context/context.dart:100: HashMap<AnalysisTarget, List<PendingFuture>> _pendingFutureSources = Rename it?
5 years, 7 months ago (2015-05-02 16:35:49 UTC) #3
Brian Wilkerson
https://codereview.chromium.org/1127483002/diff/1/pkg/analyzer/lib/src/context/context.dart File pkg/analyzer/lib/src/context/context.dart (right): https://codereview.chromium.org/1127483002/diff/1/pkg/analyzer/lib/src/context/context.dart#newcode100 pkg/analyzer/lib/src/context/context.dart:100: HashMap<AnalysisTarget, List<PendingFuture>> _pendingFutureSources = Done, thanks!
5 years, 7 months ago (2015-05-03 15:05:39 UTC) #4
Brian Wilkerson
5 years, 7 months ago (2015-05-03 15:06:16 UTC) #5
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) manually as 45479 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698