Issue 1127453003: VM: Don't emit usage counter and range feedback code and when optimizations are disabled.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1127453003: VM: Don't emit usage counter and range feedback code and when optimizations are disabled. (Closed)

Created:
5 years, 7 months ago by Florian Schneider

Modified:
5 years, 7 months ago

Reviewers:
srdjan

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

VM: Don't emit usage counter code when optimizations are disabled. Committed: https://code.google.com/p/dart/source/detail?r=45530

Patch Set 2 : addressed comments #

Created: 5 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+185 lines, -138 lines)			Patch
M	runtime/vm/flow_graph_compiler.cc	View		2 chunks	+3 lines, -0 lines	0 comments	Download
M	runtime/vm/stub_code.cc	View		2 chunks	+2 lines, -0 lines	0 comments	Download
M	runtime/vm/stub_code_arm.cc	View	1	5 chunks	+33 lines, -24 lines	0 comments	Download
M	runtime/vm/stub_code_arm64.cc	View	1	5 chunks	+38 lines, -29 lines	0 comments	Download
M	runtime/vm/stub_code_ia32.cc	View	1	5 chunks	+34 lines, -28 lines	0 comments	Download
M	runtime/vm/stub_code_mips.cc	View	1	5 chunks	+40 lines, -31 lines	0 comments	Download
M	runtime/vm/stub_code_x64.cc	View	1	5 chunks	+35 lines, -26 lines	0 comments	Download

Messages

Total messages: 4 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

srdjan

LGTMwC https://codereview.chromium.org/1127453003/diff/1/runtime/vm/stub_code_arm.cc File runtime/vm/stub_code_arm.cc (right): https://codereview.chromium.org/1127453003/diff/1/runtime/vm/stub_code_arm.cc#newcode1242 runtime/vm/stub_code_arm.cc:1242: if (FLAG_optimization_counter_threshold != -1) { Maybe >= 0 ...

5 years, 7 months ago (2015-05-05 07:32:57 UTC) #3

Florian Schneider

5 years, 7 months ago (2015-05-05 17:06:28 UTC) #4

Message was sent while issue was closed.

Committed patchset #2 (id:20001) manually as r45530 (presubmit successful).

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

Issue 1127453003: VM: Don't emit usage counter and range feedback code and when optimizations are disabled. (Closed)

Description

Patch Set 1 #

Patch Set 2 : addressed comments #

Messages