Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(248)

Issue 1127403004: Return empty contents for not existing sources. (Closed)

Created:
5 years, 7 months ago by scheglov
Modified:
5 years, 7 months ago
Reviewers:
Brian Wilkerson
CC:
reviews_dartlang.org
Target Ref:
refs/remotes/git-svn
Visibility:
Public.

Description

Return empty contents for not existing sources. R=brianwilkerson@google.com BUG= Committed: https://code.google.com/p/dart/source/detail?r=45778

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+68 lines, -10 lines) Patch
M pkg/analyzer/lib/src/context/cache.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M pkg/analyzer/lib/src/context/context.dart View 1 chunk +6 lines, -0 lines 0 comments Download
M pkg/analyzer/lib/src/task/dart.dart View 2 chunks +37 lines, -0 lines 0 comments Download
M pkg/analyzer/lib/src/task/general.dart View 1 chunk +3 lines, -3 lines 0 comments Download
M pkg/analyzer/test/src/context/context_test.dart View 2 chunks +3 lines, -3 lines 0 comments Download
M pkg/analyzer/test/src/task/dart_test.dart View 1 chunk +13 lines, -0 lines 0 comments Download
M pkg/analyzer/test/src/task/general_test.dart View 1 chunk +4 lines, -2 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
scheglov
5 years, 7 months ago (2015-05-13 20:23:36 UTC) #1
Brian Wilkerson
LGTM
5 years, 7 months ago (2015-05-13 20:48:31 UTC) #2
scheglov
5 years, 7 months ago (2015-05-13 20:51:15 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as 45778 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698